Drop useless phpdoc, already covered by PHP#80
Merged
Seldaek merged 1 commit intophp-fig:masterfrom Aug 21, 2024
Merged
Conversation
welcoMattic
approved these changes
Feb 21, 2024
Contributor
Author
|
cc @Crell |
Collaborator
|
I agree the docblocks no longer offer any value. However, the docblocks were included in the original PSR text. There was a formal process to add the language types years later, once language types existed. 😄 I'm hesitant to remove the docblocks now when they are still specified in the spec. |
Member
|
@Seldaek is the editor for the related PSR |
Seldaek
approved these changes
Apr 2, 2024
Collaborator
Seldaek
left a comment
Seldaek
left a comment
There was a problem hiding this comment.
As far I'm concerned I'd say ship it without vote etc.. It's an obvious cleanup of redundant info. If that's not ok per the rules someone will have to deal with a vote etc sorry i have no capacity atm
Contributor
Author
|
What is the status of this PR? I mean, What can I do to get this merged? |
Collaborator
|
Ok nobody seems to give a shit so I merged and tagged it. Thanks |
phily245
added a commit
to phily245/php-fig--log
that referenced
this pull request
Sep 9, 2024
v3.0.1 removed this line at php-fig@79dff0b#diff-ece1cc9e2cbefb0d1c511f88ab22703e9a402b9ca071df66704f1106c1433ad4L116 (in PR php-fig#80), however it isn't covered by a typehint so broke static analysis checks in consuming applications/packages using this interface
This was referenced Sep 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.