Updated doc block to be coherent with the suggested PSR#53
Merged
joelwurtz merged 1 commit intophp-http:masterfrom Jan 28, 2016
Merged
Updated doc block to be coherent with the suggested PSR#53joelwurtz merged 1 commit intophp-http:masterfrom
joelwurtz merged 1 commit intophp-http:masterfrom
Conversation
Member
|
LGTM. What about Style CI then? |
Member
Author
|
StyleCI does not like this doc block. Should I comply with the patch that StyleCI provides? Or do you want to change the config in StyleCI? |
Member
|
Good question, have no idea. We could turn off some docblock check, maybe that helps. |
Member
|
Certainly the align thing in docblock, |
Member
|
I added this in php style ci config : Then it was ok, bug is coming from separation but if we only remove this, then align has another bug :/ |
Member
|
I think for the moment we should add the blank line proposed by the fixer, it's not a big problem, and we can try to do a PR on php-cs-fixer (at least an issue) |
Member
|
Ok, let's not add those disable statements then. I agree we can live with that extra line. |
Contributor
|
👍 |
Member
Author
|
Updated |
joelwurtz
added a commit
that referenced
this pull request
Jan 28, 2016
Updated doc block to be coherent with the suggested PSR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #51