Accept Throwable for onRejected and expand return type for wait()#30
Merged
dbu merged 6 commits intophp-http:1.xfrom Nov 8, 2023
Merged
Accept Throwable for onRejected and expand return type for wait()#30dbu merged 6 commits intophp-http:1.xfrom
dbu merged 6 commits intophp-http:1.xfrom
Conversation
1 task
Contributor
|
1.6 is from april 2022, so i think that seems reasonable to expect. lets add that and avoid further confusion for consumers phpstan checks. |
dbu
reviewed
Nov 8, 2023
Ndiritu
commented
Nov 8, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
wait()to handle the possiblevoidandnullreturn values based on the method's description.\Throwableinterface instead of\ExceptioninonRejectedcallable parameter typeChecklist
To Do
wait()e.g.@return ($unwrap is true ? T : null|void). This would eliminate further PHPStan failures for dependent libs, however this syntax requires PHPStan^1.6.0. Would this be a better approach? At the moment, usingT|null|voidcould cause further PHPStan failures for dependent libs. Would these further failures be considered a BC break?