Skip to content

Conversation

@vitalybaev
Copy link
Contributor

This properties have wrong types in PHPDoc

@coveralls
Copy link

coveralls commented Apr 30, 2018

Pull Request Test Coverage Report for Build 595

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 96.057%

Files with Coverage Reduction New Missed Lines %
src/Common/JsonSchema/JsonPatch.php 1 100.0%
Totals Coverage Status
Change from base Build 582: -0.06%
Covered Lines: 1681
Relevant Lines: 1750

💛 - Coveralls

@haphan haphan merged commit 3374e2b into php-opencloud:master May 2, 2018
@haphan
Copy link
Collaborator

haphan commented May 2, 2018

thanks @vitalybaev 🚀

@vitalybaev vitalybaev deleted the fixed-object-storage-phpdoc-types branch May 3, 2018 17:08
@vitalybaev
Copy link
Contributor Author

@haphan Thanks a lot! Could you ship a new patch release, cause Scrutinizer marks our code as bug due to incompatible types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants