Add extra php attribute to methods for 8+ Fixes #52#53
Merged
Conversation
These functions are giving notices on php 8+. The fix is adding a extra php attribute to the methods: #[ReturnTypeWillChange]
Member
:) |
Member
|
I'm very-very happy for your PR. What do you think about my commits? |
Contributor
Author
|
The changes all seem fine by me. One small note, that doesn't need to be changed. |
Member
|
All right. I agree. But Bash is "improved POSIX" :) |
Member
|
While releasing v6.0.2 Viktor must work! |
Member
|
This error does not belong here. |
szepeviktor
reviewed
Sep 30, 2022
| for METHOD in "${REQUESTS_V1_METHODS[@]}"; do | ||
| # Get the line number where the method is defined. | ||
| LINE="$(php -r "require 'wordpress-stubs.php'; print (new ReflectionMethod('${METHOD}'))->getStartLine();")" | ||
| echo "${METHOD} is defined on line ${LINE}." |
Member
There was a problem hiding this comment.
@janw-me I've added a check here. Some methods do not exist in earlier core releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are giving notices on php 8+.
The fix is adding a extra php attribute to the methods: #[ReturnTypeWillChange]
There where a couple of difficulties. So I took a different approach.
sedfor a method couldn't target the function of a specific class. So I used php reflection.#[ReturnTypeWillChange]So I check if it's not already present.So when PHP 8.1: fix deprecation warnings WordPress/Requests#505 lands, this won't create duplicates.
Overall fun thing to include.