Remove the need to maintain these args shapes #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Makes a lot of sense to do it that way and is much less cumbersome to maintain! |
Contributor
|
@szepeviktor @johnbillion's suggestion is way better than replicating the shapes. I strongly support merging this and wait for WP to update the doc block. |
Member
|
I will merge this on the day WP 6.3.0 is released. Is that what you thought? |
Contributor
Author
|
You can merge this now in case we get some more releases in the 6.2.x branch, and then when 6.3 lands we'll pull it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IanDelMar This simplifies these two parameter types so we don't need to maintain the shapes. What do you think?
In #81 I added
See register_post_type() for information on accepted argumentsandSee register_taxonomy() for information on accepted argumentsto the args descriptions in the constructors in WordPress core and then regenerated the stubs, to demonstrate how the args inheritance works. I can add those to core but we'll need to wait until WordPress 6.3 is released to benefit from them. This PR could be merged in the meantime.