Remove doctrine annotations#186
Conversation
|
Hm, I'm thinking about doing a minor release for this... but if we completely drop annotation files like |
|
I guess you are right. Some users might use them in an other way than annotations. |
This reverts commit b09fb37.
|
I've have added a |
bocharsky-bw
left a comment
There was a problem hiding this comment.
I'm fine for now with @deprecated for now, though I think if we really want to push users to get rid of it in their projects, we may need to trigger_deprecation() also, see https://symfony.com/doc/current/contributing/code/conventions.html#deprecating-code . Because simple @deprecated won't be enough to trigger a deprecation notice for users. But I think we can do it in another PR too
|
|
|
Thank you for working on this! Let's merge |
Closes #181
Closes #176
At first it thought about keeping the annotation classes, but they become useless.
Edit : Keep them anyway to avoid potential BC Break