Skip to content

Conversation

@jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 11, 2022

MurmurHash3

Added support for MurmurHash3 with streaming support. The following variants are implemented:

  • murmur3a, 32-bit hash
  • murmur3c, 128-bit hash for x86
  • murmur3f, 128-bit hash for x64

xxHash

Added support for xxHash. The following variants are implemented:

  • xxh32, 32-bit hash
  • xxh64, 64-bit hash
  • xxh3, 64-bit hash
  • xxh128, 128-bit hash

Refs:

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I'm not 100% convinced that it makes much sense to update the list of algorithms in the example output (it changes "all the time"), but I'm not against doing it.

@jrfnl jrfnl force-pushed the php-8.1/hash-hash_algos-update branch from a52d955 to fa1aba3 Compare March 11, 2022 12:46
> **MurmurHash3**
>
> Added support for MurmurHash3 with streaming support. The following variants are implemented:
> * murmur3a, 32-bit hash
> * murmur3c, 128-bit hash for x86
> * murmur3f, 128-bit hash for x64
>
> **xxHash**
>
> Added support for xxHash. The following variants are implemented:
> * xxh32, 32-bit hash
> * xxh64, 64-bit hash
> * xxh3, 64-bit hash
> * xxh128, 128-bit hash

Refs:
* https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.hash.murmurhash3
* php/php-src#6059
* php/php-src@72e91e9
* https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.hash.xxhash
* php/php-src#6524
* php/php-src@23590f7
@jrfnl jrfnl force-pushed the php-8.1/hash-hash_algos-update branch from fa1aba3 to 5fa56c3 Compare March 11, 2022 12:47
@jrfnl
Copy link
Contributor Author

jrfnl commented Mar 11, 2022

Thank you for the PR!

I'm not 100% convinced that it makes much sense to update the list of algorithms in the example output (it changes "all the time"), but I'm not against doing it.

I followed by example as the list was updated for the previous PHP 7.4 update. (though realized just now I forgot to update the "As of PHP ..." bit in the leading paragraph. Fixed that now too.

@cmb69
Copy link
Member

cmb69 commented Mar 11, 2022

Thanks! I think we can commit as is, but we should revisit:
Screenshot 2022-03-11 141523

That "as of PHP …" should either go below the example script, or probably better be removed altogether, since the &example.outputs.similar; already hints that the exact output may be different.

@cmb69 cmb69 merged commit 03bb26a into php:master Mar 11, 2022
@jrfnl jrfnl deleted the php-8.1/hash-hash_algos-update branch March 11, 2022 14:36
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
> **MurmurHash3**
>
> Added support for MurmurHash3 with streaming support. The following variants are implemented:
> * murmur3a, 32-bit hash
> * murmur3c, 128-bit hash for x86
> * murmur3f, 128-bit hash for x64
>
> **xxHash**
>
> Added support for xxHash. The following variants are implemented:
> * xxh32, 32-bit hash
> * xxh64, 64-bit hash
> * xxh3, 64-bit hash
> * xxh128, 128-bit hash

Refs:
* https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.hash.murmurhash3
* php/php-src#6059
* php/php-src@72e91e9
* https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.hash.xxhash
* php/php-src#6524
* php/php-src@23590f7

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>

Closes phpGH-1451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants