Skip to content

Conversation

@tstarling
Copy link
Contributor

No description provided.

@tstarling tstarling force-pushed the libxml_get_external_entity_loader branch from b1516d9 to b997b22 Compare November 3, 2022 04:12
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I prefer to omit the folding markers (<!-- {{{ --> and <!-- }}} -->), since they don't appear to make much sense anymore. It's okay to leave them as is, though.

@tstarling
Copy link
Contributor Author

The folding markers came from the skeleton (doc-base/RFC/skeletons/function.xml). I can make a PR deleting them from there if you like.

@Girgias Girgias merged commit d0d1ec1 into php:master Nov 4, 2022
@Girgias Girgias added this to the PHP 8.2 milestone Nov 12, 2022
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants