Updates for RFC: Locale-independent case conversion #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tstarling
commented
Nov 3, 2022
tstarling
commented
- Add a detailed description of what is meant by ASCII case conversion to strtolower() and strtoupper().
- Replace locale-related text on ucfirst(), lcfirst() and ucwords() with text about ASCII case conversion.
- Remove entity note.locale-single-byte since it was only used on ucwords().
- Add changelog entries to all the functions mentioned in the RFC.
* Add a detailed description of what is meant by ASCII case conversion to strtolower() and strtoupper(). * Replace locale-related text on ucfirst(), lcfirst() and ucwords() with text about ASCII case conversion. * Remove entity note.locale-single-byte since it was only used on ucwords(). * Add changelog entries to all the functions mentioned in the RFC.
tstarling
force-pushed
the
strtolower-ascii
branch
from
6cc4212 to
dd861d2
Compare
Girgias
requested changes
Nov 4, 2022
Co-authored-by: George Peter Banyard <girgias@php.net>
tstarling
force-pushed
the
strtolower-ascii
branch
from
e7757f7 to
a98fffb
Compare
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
* Add a detailed description of what is meant by ASCII case conversion to strtolower() and strtoupper(). * Replace locale-related text on ucfirst(), lcfirst() and ucwords() with text about ASCII case conversion. * Remove entity note.locale-single-byte since it was only used on ucwords(). * Add changelog entries to all the functions mentioned in the RFC. Co-authored-by: George Peter Banyard <girgias@php.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.