Skip to content

Use new class synopsis markup#2611

Merged
Girgias merged 1 commit into
php:masterfrom
kocsismate:new-class-markup
Aug 30, 2023
Merged

Use new class synopsis markup#2611
Girgias merged 1 commit into
php:masterfrom
kocsismate:new-class-markup

Conversation

@kocsismate
Copy link
Copy Markdown
Member

Following php/phd#77

@kocsismate kocsismate requested a review from Girgias July 27, 2023 18:54
@kocsismate kocsismate requested a review from TimWolla as a code owner July 27, 2023 18:54
Copy link
Copy Markdown
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack for reference/random/

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not just fix the interfaces for the time being, and possibly continue to use the legacy markup for classes?

Not sure if I really want to dump a 260 file change onto translations, but maybe @mumumu, @saundefined, @sy-records are fine with that?

@saundefined
Copy link
Copy Markdown
Member

It's not a big problem for me, thanks!

But I'd also listen to other translators' opinions as well.

@kocsismate
Copy link
Copy Markdown
Member Author

an we not just fix the interfaces for the time being, and possibly continue to use the legacy markup for classes?

I'm fine with fixing the interfaces first in a separate commit, but I'd be a bit upset if classes had to use the old syntax because then I would have to conditionally generate a different markup for classes and interfaces which would complicate gen_stub even more.

@Girgias
Copy link
Copy Markdown
Member

Girgias commented Jul 28, 2023

an we not just fix the interfaces for the time being, and possibly continue to use the legacy markup for classes?

I'm fine with fixing the interfaces first in a separate commit, but I'd be a bit upset if classes had to use the old syntax because then I would have to conditionally generate a different markup for classes and interfaces which would complicate gen_stub even more.

Yeah I would want them to be the same too, but let's first do interfaces to fix the immediate issues, and lets merge classes a tad later

@kocsismate
Copy link
Copy Markdown
Member Author

OK, I'll create a new PR soon only containing the interfaces :)

@kocsismate
Copy link
Copy Markdown
Member Author

@Girgias Can I merge this?

@Girgias
Copy link
Copy Markdown
Member

Girgias commented Jul 31, 2023

Give me/doc-fr until the end of the week to try to get our stuff in order :)

@kocsismate
Copy link
Copy Markdown
Member Author

@Girgias What about now? :)

@kocsismate kocsismate requested a review from Girgias August 29, 2023 07:26
@Girgias Girgias merged commit 14767af into php:master Aug 30, 2023
@kocsismate kocsismate deleted the new-class-markup branch August 30, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants