Use new class synopsis markup#2611
Conversation
Girgias
left a comment
There was a problem hiding this comment.
Can we not just fix the interfaces for the time being, and possibly continue to use the legacy markup for classes?
Not sure if I really want to dump a 260 file change onto translations, but maybe @mumumu, @saundefined, @sy-records are fine with that?
|
It's not a big problem for me, thanks! But I'd also listen to other translators' opinions as well. |
I'm fine with fixing the interfaces first in a separate commit, but I'd be a bit upset if classes had to use the old syntax because then I would have to conditionally generate a different markup for classes and interfaces which would complicate gen_stub even more. |
Yeah I would want them to be the same too, but let's first do interfaces to fix the immediate issues, and lets merge classes a tad later |
|
OK, I'll create a new PR soon only containing the interfaces :) |
Following php/phd#77
e3127dc to
b851d14
Compare
|
@Girgias Can I merge this? |
|
Give me/doc-fr until the end of the week to try to get our stuff in order :) |
|
@Girgias What about now? :) |
Following php/phd#77