Skip to content

Updates the DS interfaces to use new syntax#2641

Merged
Girgias merged 1 commit into
php:masterfrom
mallardduck:ds-fix-new-syntax
Aug 3, 2023
Merged

Updates the DS interfaces to use new syntax#2641
Girgias merged 1 commit into
php:masterfrom
mallardduck:ds-fix-new-syntax

Conversation

@mallardduck
Copy link
Copy Markdown
Contributor

@mallardduck mallardduck commented Aug 3, 2023

per title, this fixes the current build issues.
this is accomplished by updating the Data Structures docs to match the examples from here: #2563
once merged these interfaces will use the proper new syntax and fixes both the builds and the current render issues on php.net

@afilina
Copy link
Copy Markdown
Contributor

afilina commented Aug 3, 2023

Just to confirm, does this mean that the docs become buildable using phd's HEAD?
Reference: #2638 (comment)

@mallardduck
Copy link
Copy Markdown
Contributor Author

@afilina - yeah, this PR should allow all HEAD tags for PHD/en/src to play nice again. Sorry for the headache there on your PR, this is all kinda my fault when I created a bodge level (in hindsight) interface fix. And then @Girgias found a more proper solution which required some updates that took time - and by then I forgot to follow up with this needed PR.

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why I don't have the build failures :(

@Girgias Girgias merged commit ae6b3ce into php:master Aug 3, 2023
@Lewiscowles1986
Copy link
Copy Markdown
Contributor

😊 I had cloned @afilina branch... So my master was never changing to be ahead. I was internally screaming just now as it still wasn't working, but upon debugging my setup; my commit sha was not updating. git remote -v to the rescue. It now builds 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants