Updates the DS interfaces to use new syntax#2641
Conversation
|
Just to confirm, does this mean that the docs become buildable using phd's HEAD? |
|
@afilina - yeah, this PR should allow all HEAD tags for PHD/en/src to play nice again. Sorry for the headache there on your PR, this is all kinda my fault when I created a bodge level (in hindsight) interface fix. And then @Girgias found a more proper solution which required some updates that took time - and by then I forgot to follow up with this needed PR. |
Girgias
left a comment
There was a problem hiding this comment.
I still don't understand why I don't have the build failures :(
|
😊 I had cloned @afilina branch... So my master was never changing to be ahead. I was internally screaming just now as it still wasn't working, but upon debugging my setup; my commit sha was not updating. |
per title, this fixes the current build issues.
this is accomplished by updating the Data Structures docs to match the examples from here: #2563
once merged these interfaces will use the proper new syntax and fixes both the builds and the current render issues on php.net