Skip to content

Revert "Fix GH-2635: Fix switch alternative syntax (#2648)" #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 1 commit into from
Aug 21, 2023
Merged

Revert "Fix GH-2635: Fix switch alternative syntax (#2648)" #2693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions language/control-structures/alternative-syntax.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ endif;
<programlisting role="php">
<![CDATA[
<?php switch ($foo): ?>

<?php case 1: ?>
...
<?php endswitch; ?>
<?php endswitch ?>
Comment on lines -73 to +72
Copy link
Copy Markdown
Member Author

@TimWolla TimWolla Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the semicolon be preserved here?

Copy link
Copy Markdown
Member

@Girgias Girgias Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah keep the semicolons, both variants are fine.

Copy link
Copy Markdown
Member Author

@TimWolla TimWolla Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've re-added them in #2699 (which I'll immediately merge) to have them in a dedicated commit with a proper message. The “joys” of commit squashing 😔

]]>
</programlisting>
</informalexample>
Expand All @@ -86,7 +85,7 @@ endif;
<?php switch ($foo): ?>
<?php case 1: ?>
...
<?php endswitch; ?>
<?php endswitch ?>
]]>
</programlisting>
</informalexample>
Expand Down