Skip to content

[PHP 8.3] It is now possible to lint multiple files.#2917

Merged
jimwins merged 3 commits into
php:masterfrom
mumumu:php83-now-possible-to-lint-multiple-files
Oct 1, 2024
Merged

[PHP 8.3] It is now possible to lint multiple files.#2917
jimwins merged 3 commits into
php:masterfrom
mumumu:php83-now-possible-to-lint-multiple-files

Conversation

@mumumu
Copy link
Copy Markdown
Member

@mumumu mumumu commented Nov 5, 2023

@mumumu mumumu added this to the PHP 8.3 milestone Nov 5, 2023
Comment thread features/commandline.xml
Comment on lines +549 to +553
<note>
<para>
As of PHP 8.3.0, it is possible to check multiple files.
</para>
</note>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it better to write something more generic in the main paragraph and add a warning that the feature is not available prior to 8.3, would be more future proof

Comment thread features/commandline.xml Outdated
@jimwins
Copy link
Copy Markdown
Member

jimwins commented Sep 29, 2024

I think my re-write addresses the review feedback, and also stops giving the questionable guidance to just use -f to get fatal syntax errors.

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits but LGTM

Comment thread features/commandline.xml Outdated
Comment thread features/commandline.xml Outdated
Co-authored-by: Gina Peter Banyard <girgias@php.net>
@jimwins jimwins merged commit 725cead into php:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants