[PHP 8.3] New DOM methods#2922
Merged
Merged
Conversation
saundefined
force-pushed
the
php83-dom
branch
from
28c2184 to
cfe1f23
Compare
ndossche
requested changes
Nov 6, 2023
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Thanks a lot for this Sergey!
Here's a first round of feedback 🙂
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Member
Author
|
@nielsdos, thanks a lot! |
Member
|
No no, thank you ;) |
Girgias
reviewed
Nov 6, 2023
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Girgias
approved these changes
Nov 7, 2023
Member
|
Thank you! |
ndossche
reviewed
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.