Skip to content

[PHP 8.3] posix documentation updates#2928

Merged
devnexen merged 1 commit into
php:masterfrom
devnexen:posix_83_stubs
Nov 10, 2023
Merged

[PHP 8.3] posix documentation updates#2928
devnexen merged 1 commit into
php:masterfrom
devnexen:posix_83_stubs

Conversation

@devnexen
Copy link
Copy Markdown
Member

@devnexen devnexen commented Nov 8, 2023

No description provided.

@devnexen devnexen force-pushed the posix_83_stubs branch 2 times, most recently from 9193543 to eb2e55a Compare November 8, 2023 20:39
Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but LGTM, thank you!

<methodparam><type>string</type><parameter>filename</parameter></methodparam>
<methodparam choice="opt"><type>int</type><parameter>flags</parameter><initializer>0</initializer></methodparam>
</methodsynopsis>
&warn.undocumented.func;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&warn.undocumented.func;

Comment thread reference/posix/functions/posix-eaccess.xml Outdated
Comment thread reference/posix/functions/posix-fpathconf.xml Outdated
Comment thread reference/posix/functions/posix-pathconf.xml
Comment thread reference/posix/functions/posix-sysconf.xml Outdated
Comment thread reference/posix/functions/posix-sysconf.xml Outdated
@devnexen
Copy link
Copy Markdown
Member Author

Note to myself, documenting constants at some point.

Co-authored-by: Gina Peter Baynard <girgias@php.net>
@devnexen devnexen merged commit 9c16642 into php:master Nov 10, 2023
@devnexen devnexen deleted the posix_83_stubs branch November 30, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants