[PHP 8.3] Adding new socket_atmark call.#2946
Merged
Merged
Conversation
devnexen
force-pushed
the
sockets_83_update
branch
from
b3d1bdb to
9dbd75e
Compare
devnexen
force-pushed
the
sockets_83_update
branch
from
9dbd75e to
5485244
Compare
Girgias
requested changes
Nov 18, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Please amend versions.xml but otherwise LGTM.
| <?php | ||
| // Create a new socket | ||
| $sock = socket_create(AF_INET, SOCK_STREAM, SOL_TCP); | ||
| echo socket_atmark($sock); |
Member
There was a problem hiding this comment.
Echoing booleans is not ideal IMHO.
Suggested change
| echo socket_atmark($sock); | |
| var_dump(socket_atmark($sock)); |
Girgias
approved these changes
Nov 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.