Add Override Attribute stub#2996
Merged
Merged
Conversation
Member
Should probably be unified then. |
TimWolla
approved these changes
Dec 8, 2023
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Looks good for a stub, but perhaps steal the example from here: https://www.php.net/releases/8.3/en.php#override_attribute. Shouldn't take a relevant amount of additional time and makes the page much more useful right away.
Girgias
force-pushed
the
override-class
branch
from
f0ec268 to
9db49a5
Compare
TimWolla
approved these changes
Dec 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... I don't remember what the reason was to move the
AllowDynamicPropertiesClass methods definition out of the subfolder like I did it this time.But I can't see any issues with it.