Remove COM constant values#3051
Merged
Merged
Conversation
Girgias
reviewed
Dec 31, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Possibly having the whitespace removal as a seperate commit with [skip-revcheck] would be good
haszi
force-pushed
the
Remove-COM-constant-values
branch
from
1d12b81 to
225b4d4
Compare
Girgias
approved these changes
Jan 3, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Could you rebase and change the commit description of the last commit to be:
Add missing literal tags in VT_DATE description
?
Co-authored-by: Gina Peter Banyard <girgias@php.net>
haszi
force-pushed
the
Remove-COM-constant-values
branch
from
105d259 to
0aa23d5
Compare
Girgias
approved these changes
Jan 3, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Thank you!
And sorry for being so annoying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all the values and references to PHP 7.0 from the table as advised here and here.