Skip to content

[PHP 8.3] Update Intl functions return values #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 1 commit into from
Jan 10, 2024
Merged

[PHP 8.3] Update Intl functions return values #3093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions reference/intl/dateformatter/settimezone.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
&style.oop;
</para>
<methodsynopsis role="IntlDateFormatter">
<modifier>public</modifier> <type class="union"><type>bool</type><type>null</type></type><methodname>IntlDateFormatter::setTimeZone</methodname>
<modifier>public</modifier> <type>bool</type><methodname>IntlDateFormatter::setTimeZone</methodname>
<methodparam><type class="union"><type>IntlTimeZone</type><type>DateTimeZone</type><type>string</type><type>null</type></type><parameter>timezone</parameter></methodparam>
</methodsynopsis>
<para>
&style.procedural;
</para>
<methodsynopsis>
<type class="union"><type>bool</type><type>null</type></type><methodname>datefmt_set_timezone</methodname>
<type>bool</type><methodname>datefmt_set_timezone</methodname>
<methodparam><type>IntlDateFormatter</type><parameter>formatter</parameter></methodparam>
<methodparam><type class="union"><type>IntlTimeZone</type><type>DateTimeZone</type><type>string</type><type>null</type></type><parameter>timezone</parameter></methodparam>
</methodsynopsis>
Expand Down Expand Up @@ -59,10 +59,33 @@
<refsect1 role="returnvalues">
&reftitle.returnvalues;
<para>
Returns &null; on success and &false; on failure.
&return.success;
</para>
</refsect1>

<refsect1 role="changelog">
&reftitle.changelog;
<para>
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.3.0</entry>
<entry>
This function now returns &true; on success; previously it returns &null;.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</para>
</refsect1>

<refsect1 role="examples">
&reftitle.examples;
Expand Down
27 changes: 25 additions & 2 deletions reference/intl/intlbreakiterator/settext.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<refsect1 role="description">
&reftitle.description;
<methodsynopsis role="IntlBreakIterator">
<modifier>public</modifier> <type class="union"><type>bool</type><type>null</type></type><methodname>IntlBreakIterator::setText</methodname>
<modifier>public</modifier> <type>bool</type><methodname>IntlBreakIterator::setText</methodname>
<methodparam><type>string</type><parameter>text</parameter></methodparam>
</methodsynopsis>
<para>
Expand Down Expand Up @@ -37,10 +37,33 @@
<refsect1 role="returnvalues">
&reftitle.returnvalues;
<para>

&return.success;
</para>
</refsect1>

<refsect1 role="changelog">
&reftitle.changelog;
<para>
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.3.0</entry>
<entry>
This method now returns &false; on failure; previously it returns &null;.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</para>
</refsect1>

</refentry>
<!-- Keep this comment at the end of the file
Expand Down
28 changes: 26 additions & 2 deletions reference/intl/intlchar/enumcharnames.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<refsect1 role="description">
&reftitle.description;
<methodsynopsis role="IntlChar">
<modifier>public</modifier> <modifier>static</modifier> <type class="union"><type>bool</type><type>null</type></type><methodname>IntlChar::enumCharNames</methodname>
<modifier>public</modifier> <modifier>static</modifier> <type>bool</type><methodname>IntlChar::enumCharNames</methodname>
<methodparam><type class="union"><type>int</type><type>string</type></type><parameter>start</parameter></methodparam>
<methodparam><type class="union"><type>int</type><type>string</type></type><parameter>end</parameter></methodparam>
<methodparam><type>callable</type><parameter>callback</parameter></methodparam>
Expand Down Expand Up @@ -77,7 +77,31 @@
<refsect1 role="returnvalues">
&reftitle.returnvalues;
<para>
&return.nullorfalse;
&return.success;
</para>
</refsect1>

<refsect1 role="changelog">
&reftitle.changelog;
<para>
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.3.0</entry>
<entry>
This method now returns &false; on failure; previously it returns &null;.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</para>
</refsect1>

Expand Down