[PHP 8.3] Update functions#3106
Conversation
3ebbe9f to
3c8f21c
Compare
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
I stumbled upon this PR during a migration to PHP 8.3:
This seems to be not the case. As we can see at https://3v4l.org/lKNfW#v8.3.20, the value (string) Since cannot be converted to int/float. is not the case here, does this mean the documentation is inaccurate? |
|
Relevant PR: php/php-src#10161 |
|
I think we should reword the part in the documentation, at least we should fix some grammar issues (where => were): + array_sum() and array_product() now warn when values in the array cannot be converted to int/float. Previously arrays and objects were ignored whilst every other value was cast to int. Moreover, objects that define a numeric cast (e.g. GMP) are now casted instead of ignored.
- array_sum() and array_product() now warn when values in the array cannot be converted to int/float. Previously arrays and objects where ignored whilst every other value was cast to int. Moreover, objects that define a numeric cast (e.g. GMP) are now casted instead of ignored. |
|
Please open a new issue. Old PRs are basically never read nor the proper place to discuss stuff. For the grammar issues feel free to open a PR. |
No description provided.