Skip to content

[PHP 8.3] PDO_ODBC_TYPE#3185

Merged
Girgias merged 1 commit into
php:masterfrom
saundefined:php83-pdo
Feb 20, 2024
Merged

[PHP 8.3] PDO_ODBC_TYPE#3185
Girgias merged 1 commit into
php:masterfrom
saundefined:php83-pdo

Conversation

@saundefined
Copy link
Copy Markdown
Member

No description provided.

@saundefined saundefined added this to the PHP 8.3 milestone Feb 16, 2024
@saundefined saundefined requested a review from Girgias February 16, 2024 20:22
Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NattyNarwhal do you know what this new constant does?

@NattyNarwhal
Copy link
Copy Markdown
Member

IIRC it indicates the kind of ODBC library/driver manager; PHP_ODBC_TYPE just renames ODBC_TYPE, which is defined in ext/odbc/php_odbc_includes.h. Should be defined to i.e. Win32 or unixODBC.

Adjacently, I am curious if anyone's using anything other than unixODBC/Win32/maybe iODBC though. (This includes SAP DB/Empress/Solid/Db2/Adabas/etc.) A lot are essentially linking against an ODBC driver (or SQL/CLI library) directly without any driver manager, which is a bit odd. At least for Db2, there's also a dedicated extension for that which I'm also maintaining, but I'm on the i side and not z/LUW, so maybe there's some difference there.

Copy link
Copy Markdown
Member

@jhdxr jhdxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias merged commit 4f90c12 into php:master Feb 20, 2024
@saundefined saundefined deleted the php83-pdo branch February 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants