[PHP 8.3] Mention final modifier for methods coming from traits#4167
Merged
Conversation
alexandre-daubois
force-pushed
the
traits-final-method
branch
from
c9a3ba6 to
d476f01
Compare
alexandre-daubois
changed the title
final modifier for methods coming from traitsfinal modifier for methods coming from traits
Girgias
approved these changes
Nov 27, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Thank you, minor XML nit and one remark about a link but LGTM to me otherwise
Comment on lines
+550
to
+553
| <para> | ||
| As of PHP 8.3.0, the <literal>final</literal> modifier can | ||
| be applied to methods coming from traits. | ||
| </para> |
Member
There was a problem hiding this comment.
Maybe the final should also link to the final documentation page?
Suggested change
| <para> | |
| As of PHP 8.3.0, the <literal>final</literal> modifier can | |
| be applied to methods coming from traits. | |
| </para> | |
| <simpara> | |
| As of PHP 8.3.0, the <literal>final</literal> modifier can | |
| be applied to methods coming from traits. | |
| </simpara> |
Member
Author
There was a problem hiding this comment.
Thanks! What the rule to decide whether para or simpara should be used?
Member
There was a problem hiding this comment.
New style guide says to prefer <simpara> as it corresponds to a HTML <p> tag, a <para> tag allows including more complex tags inside of it (e.g. <methodsynopsis>, <simplelist>), and thus we render it as a <div>.
Member
Author
There was a problem hiding this comment.
Got it, thank you!
alexandre-daubois
force-pushed
the
traits-final-method
branch
from
d476f01 to
0b7c382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2796