[PHP 8.3] Assigning a negative index to an empty array#4173
Merged
Conversation
alexandre-daubois
changed the title
Girgias
reviewed
Nov 27, 2024
Comment on lines
+356
to
+361
| <note> | ||
| <para> | ||
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | ||
| assign the next key to <literal>0</literal>. | ||
| </para> | ||
| </note> |
Member
There was a problem hiding this comment.
Could you also add a screen tag showcasing the old output?
Suggested change
| <note> | |
| <para> | |
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | |
| assign the next key to <literal>0</literal>. | |
| </para> | |
| </note> | |
| <warning> | |
| <simpara> | |
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | |
| assign the next key to <literal>0</literal>. | |
| </simpara> | |
| </warning> |
Member
Author
There was a problem hiding this comment.
I also updated the example, it wasn't working as I expected in older versions. The new one is better: https://3v4l.org/J9ZRL
alexandre-daubois
force-pushed
the
negative-index
branch
from
466c84a to
f3e9d2a
Compare
Girgias
reviewed
Nov 28, 2024
Comment on lines
+352
to
+353
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | ||
| assign the next key to <literal>0</literal>, as shown in this example: |
Member
There was a problem hiding this comment.
Maybe?
Suggested change
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | |
| assign the next key to <literal>0</literal>, as shown in this example: | |
| Prior to PHP 8.3.0, assigning a negative integer key <literal>n</literal> would | |
| assign the next key to <literal>0</literal>, the previous example would therefore output: |
alexandre-daubois
force-pushed
the
negative-index
branch
from
f3e9d2a to
d8a00b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2796