8.4: Document all new DOM classes and methods - part 1#4212
8.4: Document all new DOM classes and methods - part 1#4212ndossche merged 45 commits intophp:masterfrom
Conversation
b40772e to
6b116fb
Compare
5b1b19a to
f762c1a
Compare
|
@Girgias I've finished with some basics. Most notably the class synopses are generated and the properties etc are all filled in. I've used xinclude quite a bit. I also fixed up some of the old DOM class descriptions. |
Girgias
left a comment
There was a problem hiding this comment.
Didn't test locally but this a pass across the whole PR
| <row xml:id="constant.domstring-size-err"> | ||
| <entry> | ||
| <constant>DOMSTRING_SIZE_ERR</constant> | ||
| <constant>DOMSTRING_SIZE_ERR</constant> / <constant>Dom\STRING_SIZE_ERR</constant> |
There was a problem hiding this comment.
The issue I can see for this, is that automatic linking for <constant>Dom\STRING_SIZE_ERR</constant> is not going to work because the row has no corresponding XML ID.
Can an XML element have 2 IDs? If yes that would fix it.
There was a problem hiding this comment.
Can an XML element have 2 IDs? If yes that would fix it.
No, but I don't think this is ever linked to directly 🤔
|
Thanks for the initial review. I pushed fixup commits so they can be validated individually, I'll later rebase this to merge the fixups with the original commits. |
0463c12 to
1e6be82
Compare
Very WIP, not ready for review yet.
TODO:
Create examples of array indexing in NamedNodeMap ?Let's do this separatelyAdd a note on top of the dom book to guide users to the new classes?Do this later once the docs are completedExplain xpath subtletiesSeparate PR