Hooks reflection examples output #4435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Not sure what I can do about that. Someone can also cherry pick my commit or use its patch file. |
Member
|
Thank you, I will merge the other PR so you can rebase onto of master. |
Girgias
reviewed
Feb 6, 2025
| // But this would set the $age to -2 without error. | ||
| $rProp->setRawValue($example, -2); | ||
| print $example->age; |
Member
There was a problem hiding this comment.
I think we mostly use echo in the manual.
Contributor
Author
There was a problem hiding this comment.
These exist in the previous commit, I'll change all print to echo.
Member
|
Sorry this took a while, can you rebase on top of master? |
ADmad
force-pushed
the
hooks-reflection
branch
from
a6454f7 to
239d017
Compare
Contributor
Author
Done |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added output for the examples added in #4110. I had to tweak the examples a bit for output readability