socket_get_option/socket_set_option SO_ACCEPTFILTER constant introduc… #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! This will be only available as of PHP 8.1.0, right? |
Member
Author
|
yes indeed :-) |
Member
|
Fine! We should also add: reference/sockets/constants.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/reference/sockets/constants.xml b/reference/sockets/constants.xml
index a9eefc3826..a9ca6571f8 100644
--- a/reference/sockets/constants.xml
+++ b/reference/sockets/constants.xml
@@ -347,6 +347,17 @@
</simpara>
</listitem>
</varlistentry>
+ <varlistentry xml:id="constant.so-acceptfilter">
+ <term>
+ <constant>SO_ACCEPTFILTER</constant>
+ (<type>string</type>)
+ </term>
+ <listitem>
+ <simpara>
+ Available as of PHP 8.1.0.
+ </simpara>
+ </listitem>
+ </varlistentry>
<varlistentry xml:id="constant.sol-socket">
<term>
<constant>SOL_SOCKET</constant> |
devnexen
force-pushed
the
socket_set_option_accept_filtr
branch
from
11bbe04 to
ca0099a
Compare
cmb69
approved these changes
Jun 4, 2021
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
LGTM! Merge will have to wait , though.
devnexen
force-pushed
the
socket_set_option_accept_filtr
branch
from
ca0099a to
c9a1841
Compare
saundefined
reviewed
Oct 8, 2021
Member
saundefined
left a comment
saundefined
left a comment
There was a problem hiding this comment.
Looks good, thank you!
my 2 cents
saundefined
reviewed
Oct 8, 2021
devnexen
force-pushed
the
socket_set_option_accept_filtr
branch
from
168db52 to
a1d065b
Compare
saundefined
approved these changes
Oct 8, 2021
devnexen
force-pushed
the
socket_set_option_accept_filtr
branch
from
ec085ae to
f68c0c1
Compare
Co-authored-by: Sergey Panteleev <sergey@php.net>
devnexen
force-pushed
the
socket_set_option_accept_filtr
branch
from
f68c0c1 to
a49116c
Compare
Member
|
@cmb69 is it time to merge the PR? |
marcovtwout
pushed a commit
to marcovtwout/doc-en
that referenced
this pull request
Dec 24, 2024
Co-authored-by: Sergey Panteleev <sergey@php.net> Closes phpGH-656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion.