Closed
Conversation
This was referenced Jan 14, 2023
dunglas
requested changes
Jan 31, 2023
| - name: Run tests | ||
| run: | | ||
| docker load -i /tmp/.builder.tar | ||
| docker run --rm frankenphp:${{ github.sha }}-builder "go test -a -v" |
Member
There was a problem hiding this comment.
We need to continue running the tests somewhere in the CI.
Contributor
Author
There was a problem hiding this comment.
Yes, this is just that I need help with this one.
| WORKDIR /go/src/app | ||
|
|
||
| COPY go.mod go.sum ./ | ||
| RUN go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get |
Member
There was a problem hiding this comment.
Can you add a comment explaining why it's necessary please?
Contributor
Author
There was a problem hiding this comment.
Separate file or what?
Member
There was a problem hiding this comment.
I don't understand what it's doing :D
2 tasks
Member
|
@back-2-95 I would really like to get this PR merged! Is there anything I can do to help? |
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
4601f31 to
c5b035a
Compare
Member
|
I rebased your branch and fixed and issue with the Dockerfile versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bullseyeandalpine 3.17Dockerfile+ distro specific builder dockerfiles.dockerignorefile updatedTODO / TBD
Notes
Testing
Show what is about to go down:
Build all images locally for arm64 arch (with
--loadand--set "*.platform=linux/arm64"flags):Same as previous but build only 1 target from
docker-bake.hcl:Build locally and override image name:
Build and push all images with override image name (needs you logged in to Docker Hub or some other registry):