Add Attribute linking#127
Merged
Merged
Conversation
Member
|
Do you plan to add support for displaying other types of attributes? Or is there any technical limitation? |
kocsismate
approved these changes
May 19, 2024
Member
|
gen_stub.php counterpart: php/php-src#14270 |
Contributor
Author
This PR supports 'known' attributes on method and function parameters. 'Known' in this context means an attribute that has been declared in the documentation with an ID in the As far as this PRs limitation, this implementation doesn't support namespaced attributes and does not support linking an attribute on a return type either. It wouldn't be hard to add these though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for attributes in the format described in this comment and generates links to the documentation pages of known predefined attributes.
Edit:
As a side note, there are 129 additional attributes in
php-srcstub files that are not documented indoc-en.