Fix variation5-win32(-mb).phpt wrt. parallel test execution#10189
Closed
cmb69 wants to merge 1 commit into
Closed
Conversation
Each test should use its own temporary filenames to avoid issues when the tests are executed in parallel[1]. We also silence the `unlink()` calls in the CLEAN section just in case. And while we're at it, we also remove the erroneous comment; there is no symlinking involved for the Windows test variants. [1] <php#10175 (comment)>
Girgias
approved these changes
Dec 30, 2022
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Thank you!
So that was my mistake in reusing the same temporary file name >.>
Member
Author
Well, your fix was already a huge improvement. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each test should use its own temporary filenames to avoid issues when the tests are executed in parallel[1]. We also silence the
unlink()calls in the CLEAN section just in case.And while we're at it, we also remove the erroneous comment; there is no symlinking involved for the Windows test variants.
[1] #10175 (comment)
cc @Girgias