Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind #13099
Conversation
…al() function that may be overriden for valgrind This is a more safely way to fix phpGH-9068
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
The reason I did not fix it this way is because I was afraid this could negatively impact performance of normal executions, while the issue only happens when people want to debug using Valgrind.
In any case, this solution seems safer and looks correct. I tested and it works. Thanks.
Yeah, I understood, but the degradation is really small (valgrind shows 0.0004% more instructions on 100 requests to wordpress). Also your solution wasn't complete as it didn't prevent inlining (I saw it with CLANG).
Thanks for taking a look. |
* PHP-8.2: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099)
* PHP-8.3: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099)
Measuring this with valgrind doesn't make any sense of course, but analysing the call traces, I saw that zend_string_equal_val() was never called from zend_string.h at all. |
…al() function that may be overriden for valgrind (php#13099) This is a more safely way to fix phpGH-9068
…al() function that may be overriden for valgrind (php#13099) This is a more safely way to fix phpGH-9068
…al() function that may be overriden for valgrind (php#13099) This is a more safely way to fix phpGH-9068
* PHP-8.1: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099) Skip lc_ctype_inheritance.phpt on macos 15+
* PHP-8.2: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099) Skip lc_ctype_inheritance.phpt on macos 15+
* PHP-8.3: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099) Skip lc_ctype_inheritance.phpt on macos 15+
* PHP-8.4: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099) Skip lc_ctype_inheritance.phpt on macos 15+
* PHP-8.5: Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind (#13099) Skip lc_ctype_inheritance.phpt on macos 15+
2 participants
This is a more safely way to fix GH-9068