Remove unused <extension>_SHARED_LIBADD variables #13361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used to store libraries needed to link when extension is shared and needs libraries linked to it. Since other similar types of extensions don't have these variables substituted in Makefile, these can be also removed. The filter and mysqli don't need any libraries for linking here.
github-actions
bot
added
Category: Build System
Extension: filter
Extension: mysqli
labels
devnexen
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used to store libraries needed to link when extension is shared and needs libraries linked to it. Since other similar types of extensions don't have these variables substituted in Makefile, these can be also removed. The filter and mysqli don't need any libraries for linking here.