Fix bug #81227: PDO::inTransaction reports false when in transaction #14268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
approved these changes
May 19, 2024
Member
SakiTakamachi
left a comment
SakiTakamachi
left a comment
There was a problem hiding this comment.
LGTM, there's only one nits, but it makes sense to me :)
Comment on lines
285
to
293
| static bool pdo_sqlite_in_transaction(pdo_dbh_t *dbh) | ||
| { | ||
| pdo_sqlite_db_handle* H = (pdo_sqlite_db_handle*) dbh->driver_data; | ||
| return H->db && sqlite3_get_autocommit(H->db) == 0; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
- SQLite3 does not allow to explicitly turn off autocommit mode other than manually starting a transaction
- Manual transactions always exist when autocommit mode is off
Since this kind of behavior is specific to SQLite, it might be better to leave a comment.
ndossche
force-pushed
the
pdo-sqlite-transaction
branch
2 times, most recently
from
868e69c to
492aa9e
Compare
adamziel
added a commit
to WordPress/sqlite-database-integration
that referenced
this pull request
Dec 18, 2025
Extracting smaller chunks from #291 so we can review and merge them independently. This PR includes the following changes: - Removed support for nested transactions. MySQL doesn't support them. - Implemented PDO-like APIs for start transaction, commit, and rollback. - The PDO-like APIs differ from an equivalent SQL command in that they always throw an exception in scenarios when a transaction was already started or not yet started (depending on the method), irrespective of the `ATTR_ERRMODE` setting. - Polyfill `PDO::inTransaction()` on PHP < 8.4, where it is not reliable ([issue](https://bugs.php.net/bug.php?id=81227), [PR](php/php-src#14268)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of tracking the transaction state internally, implement the internal PDO getter to check with the sqlite library itself.
Fixes https://bugs.php.net/bug.php?id=81227
Applying to master only because this bugfix is a behaviour change.