Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented May 29, 2024

This removes unused header includes, and for mbstring include the intrinsic headers

@Girgias Girgias force-pushed the ext-headers-cleanup branch from b98b253 to 3293d2b Compare May 29, 2024 18:52
@Girgias Girgias marked this pull request as ready for review May 29, 2024 22:22
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posix/pdo_pgsql look good to me

Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for libxml

Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for odbc

@Girgias Girgias merged commit 25a5146 into php:master Jun 1, 2024
@Girgias Girgias deleted the ext-headers-cleanup branch June 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants