ext/standard: refactor Windows codepage tests #20689
Draft
+177
−520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
win-file-codepoint-tests
branch
2 times, most recently
from
542382c to
43a0ed4
Compare
Most of the tests do not require the iconv extension. Moreover, due to them being compiled as shared libraries and loaded via the --EXTENSIONS-- section of the test it is highly likely that none of these tests were being run.
Girgias
force-pushed
the
win-file-codepoint-tests
branch
from
43a0ed4 to
7ef327d
Compare
Girgias
force-pushed
the
win-file-codepoint-tests
branch
from
7ef327d to
2ec9127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests do not require the iconv extension.
Moreover, due to them being compiled as shared libraries and loaded via the
--EXTENSIONS--section of the test, it is highly likely that none of these tests were being run.