Convert remaining zend_parse_parameters_none() to fast ZPP

[alexandre-daubois]

Final round. There are 2 remaining, but I'm not aware of a way to update them (because they goto or return NULL explicitly)

[TimWolla]

There are 2 remaining, but I'm not aware of a way to update them (because they goto or return NULL explicitly)

Do you have a link for reference?

[alexandre-daubois]

Of course, here they are:

php-src/ext/spl/spl_array.c

Lines 1227 to 1229 in 11a9574

	if (zend_parse_parameters_none() == FAILURE) {
	goto exit;
	}

php-src/ext/spl/spl_iterators.c

Lines 1345 to 1347 in 11a9574

	if (zend_parse_parameters_none() == FAILURE) {
	return NULL;
	}

[Girgias]

Submitted #21349 for the one in spl_array.c.

[alexandre-daubois]

Thanks Gina! Should something similar be done for the iterators? It would require to refactor the switch in spl_dual_it_construct(), and ultimately use fast ZPP for the different cases (or at least lay the groundwork if we'd like to convert them in the future)

[Girgias]

Thanks Gina! Should something similar be done for the iterators? It would require to refactor the switch in spl_dual_it_construct(), and ultimately use fast ZPP for the different cases (or at least lay the groundwork if we'd like to convert them in the future)

Meh, it might make sense to extract them because there is little common ground, extracting the AppendIterator constructor was easy: #21367