Skip to content

Migrate skip checks to --EXTENSIONS--, p3 #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikic merged 1 commit into from
Apr 3, 2021
Merged

Migrate skip checks to --EXTENSIONS--, p3 #6830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 3 additions & 4 deletions ext/ftp/tests/001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
FTP login
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
6 changes: 4 additions & 2 deletions ext/ftp/tests/002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
--TEST--
FTP login (SSL)
--EXTENSIONS--
ftp
pcntl
openssl
--SKIPIF--
<?php
$ssl = 1;
require 'skipif.inc';
if (!function_exists("ftp_ssl_connect")) die("skip ftp_ssl is disabled");
?>
--FILE--
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
FTP cwd
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/004.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
FTP with bogus parameters
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
FTP with bogus server responses
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$bogus = 1;
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/007.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ FTP with bogus resource
--CREDITS--
Michael Paul da Rosa <michael [at] michaelpaul [dot] com [dot] br>
PHP TestFest Dublin 2017
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$ftp = tmpfile();
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug27809.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #27809 (ftp_systype returns null)
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$bug27809=true;
Expand Down
6 changes: 4 additions & 2 deletions ext/ftp/tests/bug37799.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
--TEST--
Bug #37799 (ftp_ssl_connect() falls back to non-ssl connection)
--EXTENSIONS--
ftp
pcntl
openssl
--SKIPIF--
<?php
$ssl = 1;
require 'skipif.inc';
if (!function_exists("ftp_ssl_connect")) die("skip ftp_ssl is disabled");
?>
--FILE--
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug39458-2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #39458 (ftp_nlist() returns false on empty directories (other server behaviour))
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$bug39458=1;
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug39458.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #39458 (ftp_nlist() returns false on empty directories)
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug39583-2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #39583 (FTP always transfers in binary mode)
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug39583.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #39583 (FTP always transfers in binary mode)
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$bug39583=1;
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug7216-2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #7216 (ftp_mkdir returns nothing (2))
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/bug7216.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
Bug #7216 (ftp_mkdir returns nothing)
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
$bug7216=true;
Expand Down
6 changes: 3 additions & 3 deletions ext/ftp/tests/dead-resource.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
--TEST--
Attempt to use a closed FTPConnection
--SKIPIF--
<?php
require 'skipif.inc';
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
4 changes: 3 additions & 1 deletion ext/ftp/tests/filesize_large.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
--TEST--
Verify php can handle filesizes >32bit
--EXTENSIONS--
ftp
pcntl
--SKIPIF--
<?php
require 'skipif.inc';
if (2147483647 == PHP_INT_MAX) {
die('skip 64-bit only');
}
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_alloc_basic1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_alloc returns true
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_alloc_basic2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_alloc returns true
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_append.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
--TEST--
ftp_append() create new file and append something
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_chmod_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_chmod returns file mode
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
6 changes: 3 additions & 3 deletions ext/ftp/tests/ftp_constructor.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
--TEST--
Attempt to instantiate an FTPConnection directly
--SKIPIF--
<?php
require 'skipif.inc';
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php

Expand Down
5 changes: 3 additions & 2 deletions ext/ftp/tests/ftp_delete.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ Testing ftp_delete basic functionality
Gabriel Caruso (carusogabriel34@gmail.com)
Contributed by Ward Cappelle <wardcappelle@gmail.com>
User Group: PHP-WVL & PHPGent #PHPTestFest
--SKIPIF--
<?php require 'skipif.inc'; ?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_exec_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_exec returns true
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_fget_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
FTP ftp_fget file for both binary and ASCII transfer modes
--CREDITS--
Nathaniel McHugh
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_fget_basic1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_fget ignore autoresume if autoseek is switched off
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_fget_basic2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_fget autoresume
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_fget_basic3.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ Testing ftp_fget resume parameter
--CREDITS--
Rodrigo Moyle <eu [at] rodrigorm [dot] com [dot] br>
#testfest PHPSP on 2009-06-20
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
5 changes: 3 additions & 2 deletions ext/ftp/tests/ftp_fput.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
Testing ftp_fput basic functionality
--CREDITS--
Gabriel Caruso (carusogabriel34@gmail.com)
--SKIPIF--
<?php require 'skipif.inc'; ?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
7 changes: 3 additions & 4 deletions ext/ftp/tests/ftp_get_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
FTP ftp_get file for both binary and ASCII transfer modes
--CREDITS--
Nathaniel McHugh
--SKIPIF--
<?php
require 'skipif.inc';
?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
5 changes: 3 additions & 2 deletions ext/ftp/tests/ftp_get_option.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
Testing ftp_get_option basic functionality
--CREDITS--
Gabriel Caruso (carusogabriel34@gmail.com)
--SKIPIF--
<?php require 'skipif.inc'; ?>
--EXTENSIONS--
ftp
pcntl
--FILE--
<?php
require 'server.inc';
Expand Down
Loading