Migrate skip checks to --EXTENSIONS--, p4 #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Apr 6, 2021
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
That took a while, mostly fine but there are some encoding issues that need to be fixed.
For rationale, see php#6787 Extensions migrated in part 4: * simplexml * skeleton * soap * spl * sqlite3 * sysvmsg * sysvsem * tidy - also removed a check for an ancient dependency version
nikic
approved these changes
Apr 8, 2021
Member
|
It would be good to keep these slightly smaller (maybe at ~500 files), otherwise GitHub will stop showing diffs at some point. |
Contributor
Author
|
Yeah, got carried away a bit:P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rationale, see #6787
Extensions migrated in part 4: