Use camelCase method names in OCICollection and OCILob#7405
Conversation
|
Looks like historically these were lowercase: Line 880 in 3677db6 But I agree with the change to camel-case, especially as it is backwards-compatible (method names are case-insensitive). I'm wondering whether we should change the casing in OCILob at the same time though, as it also have methods like writetemporary rather than writeTemporary. |
Yeah, only
I haven't checked OCILob, but I agree with you! |
Probably doesn't ^^ I think this needs to adjust at least the PHP_METHOD for writetemporary. We don't check the OCI8 build on PHP-8.0... |
|
Ahh, I forgot about it... |
|
@nikic Are we good now? As far as I saw, the other methods are aliases |
The doc has been using
assignElem()and there is also aOCICollection::getElem()method (which was accidentally renamed fromgetelem()when arginfo got generated from the stubs), so it would be nice to keep using camelCase all overOCICollection.