Skip to content

fpm acl build fix for the older apis as there are no user/group acl s… #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devnexen wants to merge 1 commit into from
Closed

fpm acl build fix for the older apis as there are no user/group acl s… #8395

devnexen wants to merge 1 commit into from

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented Apr 18, 2022

…upport

@devnexen
Copy link
Member Author

devnexen commented Apr 20, 2022

cc @bukka

@devnexen devnexen force-pushed the php_fpm_acl_macos branch from cb958f5 to 7e4b04d Compare April 22, 2022 13:37
@Girgias Girgias requested a review from bukka April 23, 2022 11:15
bukka
bukka requested changes Apr 23, 2022
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just gave it a try and it actually disables acl for me on Ubuntu 20.04 with libacl1-dev 2.2.53-6. Without this patch it gets enabled and the test sapi/fpm/tests/socket-uds-acl.phpt still works. I think the issue is that your check doesn't actually link the library which is necessary in my case.

@devnexen devnexen force-pushed the php_fpm_acl_macos branch from 7e4b04d to a86f548 Compare April 23, 2022 15:14
bukka
bukka requested changes Apr 23, 2022
View reviewed changes
@devnexen devnexen force-pushed the php_fpm_acl_macos branch from a86f548 to e66f857 Compare April 26, 2022 16:37
bukka
bukka reviewed Apr 27, 2022
View reviewed changes
@devnexen devnexen force-pushed the php_fpm_acl_macos branch 2 times, most recently from 5add5bc to a3cf628 Compare April 28, 2022 17:52
bukka
bukka reviewed Apr 28, 2022
View reviewed changes
@devnexen devnexen force-pushed the php_fpm_acl_macos branch from a3cf628 to 525456a Compare April 28, 2022 20:26
@bukka
Copy link
Member

bukka commented Apr 29, 2022

It's all good and ready to be merged. Just need to pick the right branch.

Could you just clarify what this is exactly fixes? I see MacOS in the branch name so is that fixing ACL on MacOS? Any specific reason why you based it on master?

@devnexen
Copy link
Member Author

devnexen commented Apr 29, 2022 •
edited
Loading

Yes indeed macos supports the acl api but an old subset one (no user/group support). For the branch no idea I may have posted the PR w/o changing the target.

@bukka
Copy link
Member

bukka commented Apr 29, 2022

Ok thanks - merged as ef06f0f to PHP-8.0+

@bukka bukka closed this Apr 29, 2022
@crazywhalecc crazywhalecc mentioned this pull request Mar 10, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

Assignees

No one assigned

Labels

SAPI: fpm Waiting on Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devnexen @bukka @Girgias