Skip to content

Reuse existing output #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saundefined merged 2 commits into from
Jan 31, 2025
Merged

Reuse existing output #1180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf392d
Reuse existing output area for examples that support it
Girgias Dec 5, 2024
46b1e1f
Review comments
Girgias Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions js/interactive-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
import phpBinary from "/js/php-web.mjs";

function generateExampleOutputTitle(phpVersion) {
return "Output of the above example in PHP "+ phpVersion +":";
}

function createOutput(output) {
const container = document.createElement("div");
container.classList.add("screen", "example-contents");
const title = document.createElement("p");
title.innerText = "Output (PHP "+ PHP.version +"):";
title.innerText = generateExampleOutputTitle(PHP.version);
container.appendChild(title);
const div = document.createElement("div");
div.classList.add("examplescode");
Expand Down Expand Up @@ -56,6 +60,15 @@ async function main() {
return;
}

const exampleTitleContainer = example.nextElementSibling;
let exampleTitleParagraphElement = null;
let exampleScreenPreElement = null;
if (exampleTitleContainer !== null) {
exampleTitleParagraphElement = exampleTitleContainer.querySelector("p")
const exampleScreenContainer = exampleTitleContainer.nextElementSibling;
exampleScreenPreElement = exampleScreenContainer.querySelector("pre");
}

const code = phpcode.querySelector("code");
code.spellcheck = false;
code.setAttribute("contentEditable", true);
Expand All @@ -68,8 +81,13 @@ async function main() {

const runPhp = await PHP.loadPhp();
runPhp(phpcode.innerText);
lastOutput = createOutput(PHP.buffer.join(""));
phpcode.parentNode.appendChild(lastOutput);
if (exampleScreenPreElement !== null) {
exampleTitleParagraphElement.innerText = generateExampleOutputTitle(PHP.version);
exampleScreenPreElement.innerText = PHP.buffer.join("");
} else {
lastOutput = createOutput(PHP.buffer.join(""));
phpcode.parentNode.appendChild(lastOutput);
}
PHP.buffer.length = 0;
};

Expand Down
Loading