Add a IsNotA expression as a symmetry to the existing IsA expression.#573
Merged
fain182 merged 2 commits intophparkitect:mainfrom Feb 19, 2026
Merged
Add a IsNotA expression as a symmetry to the existing IsA expression.#573fain182 merged 2 commits intophparkitect:mainfrom
fain182 merged 2 commits intophparkitect:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
============================================
+ Coverage 97.89% 97.90% +0.01%
- Complexity 660 664 +4
============================================
Files 83 84 +1
Lines 1900 1911 +11
============================================
+ Hits 1860 1871 +11
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a
IsInstanceOfexpression for my own project that is roughly the same implementation as the newIsAexpression. But I also use aIsNotInstanceOfwhich have no equivalent yet. This PR add theIsNotAexpression that is the exact inverse of the existingIsAimplementation. I also rewrite the violations message to better align with the format of other expressions and that works better with thebecausesuffix that may be append.