Skip to content

Comments

Add a IsNotA expression as a symmetry to the existing IsA expression.#573

Merged
fain182 merged 2 commits intophparkitect:mainfrom
sukei:feature/is-not-a
Feb 19, 2026
Merged

Add a IsNotA expression as a symmetry to the existing IsA expression.#573
fain182 merged 2 commits intophparkitect:mainfrom
sukei:feature/is-not-a

Conversation

@sukei
Copy link
Contributor

@sukei sukei commented Feb 19, 2026

I created a IsInstanceOf expression for my own project that is roughly the same implementation as the new IsA expression. But I also use a IsNotInstanceOf which have no equivalent yet. This PR add the IsNotA expression that is the exact inverse of the existing IsA implementation. I also rewrite the violations message to better align with the format of other expressions and that works better with the because suffix that may be append.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.90%. Comparing base (75ccf07) to head (c18d341).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #573      +/-   ##
============================================
+ Coverage     97.89%   97.90%   +0.01%     
- Complexity      660      664       +4     
============================================
  Files            83       84       +1     
  Lines          1900     1911      +11     
============================================
+ Hits           1860     1871      +11     
  Misses           40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fain182
Copy link
Collaborator

fain182 commented Feb 19, 2026

Great, thanks!

@fain182 fain182 merged commit c45b25f into phparkitect:main Feb 19, 2026
17 checks passed
@sukei sukei deleted the feature/is-not-a branch February 20, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants