Skip to content

fix parsing class bug #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gossi merged 1 commit into from
Mar 30, 2017
Merged

fix parsing class bug #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/parser/visitor/ClassParserVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ public function visitClass(Class_ $node) {
$struct = $this->getStruct();

if ($node->extends !== null) {
$struct->setParentClassName(implode('\\', $node->extends->parts));
if ($node->extends->getType() === 'Name_FullyQualified') {
$struct->setParentClassName('\\' . implode('\\', $node->extends->parts));
} else {
$struct->setParentClassName(implode('\\', $node->extends->parts));
}
}

foreach ($node->implements as $name) {
Expand Down
4 changes: 4 additions & 0 deletions tests/fixtures/MyCollection2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?php
class MyCollection2 extends \phootwork\collection\AbstractCollection implements \phootwork\collection\Collection {

}
7 changes: 7 additions & 0 deletions tests/parser/ClassParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ public function testMyCollection() {
$this->assertEquals('phootwork\collection\AbstractCollection', $class->getParentClassName());
$this->assertTrue($class->hasInterface('phootwork\collection\Collection'));
}

public function testMyCollection2() {
$class = PhpClass::fromFile(__DIR__ . '/../fixtures/MyCollection2.php');

$this->assertEquals('\phootwork\collection\AbstractCollection', $class->getParentClassName());
$this->assertTrue($class->hasInterface('\phootwork\collection\Collection'));
}

public function testTypeClass() {
$class = PhpClass::fromFile(__DIR__ . '/../fixtures/TypeClass.php');
Expand Down