Gregory/eng 784 choreassertion executor assertion executor tracing and#11
Merged
makemake-kbo merged 13 commits intomainfrom Jun 25, 2025
Conversation
0xgregthedev
force-pushed
the
gregory/eng-784-choreassertion-executor-assertion-executor-tracing-and
branch
2 times, most recently
from
e53e609 to
ccbe471
Compare
chore: tracing improvements chore: improve traces in assertion store chore: tracing improvements chore: tracing improvements fix: syntax fix: comp issue chore: cleanup tracing chore: improve tracing data chore: improve store trace readability chore: improve tracing chore: fix tracing chore: try to fix span chore: refine state change metadata chore: use in_scope chore: improve tracing readability chore: improve tracing chore: fix comp issue chore: add more spans fix: instrument chore: abstract execute_assertion_fn chore: try to fix span chore: wth chore: change trace fmt
0xgregthedev
force-pushed
the
gregory/eng-784-choreassertion-executor-assertion-executor-tracing-and
branch
from
179ceda to
56893c0
Compare
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
fredo
reviewed
Jun 24, 2025
Contributor
|
Looks very good! I just had a quick look at |
Contributor
Author
|
makemake-kbo
approved these changes
Jun 25, 2025
fredo
deleted the
gregory/eng-784-choreassertion-executor-assertion-executor-tracing-and
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.