fix: config limit used for trigger collection, lead to potential underflow#9
Merged
0xgregthedev merged 1 commit intomainfrom Jun 10, 2025
Merged
Conversation
fredo
approved these changes
Jun 9, 2025
Contributor
fredo
left a comment
fredo
left a comment
There was a problem hiding this comment.
Looks good, nice catch.
A nice test would be to have a deployment + triggers which uses right under DEPLOYMENT_GAS_LIMIT, and another one which uses more and expects it to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The higher deployment gas value is used for deployment transactions, but the
triggers()execution used theconfig.assertion_gas_limit - deployment_gas. This resulted in an underflow when the gas in deployment exceeds the configured assertion gas limit.This limits the total gas consumption in deployment and trigger recording to be the
DEPLOYMENT_GAS_LIMIT