Skip to content

Fix type errors in exporting history after manually adding peaks #79

Merged
smoia merged 1 commit intophysiopy:masterfrom
smoia:fix/history
Aug 27, 2024
Merged

Fix type errors in exporting history after manually adding peaks #79
smoia merged 1 commit intophysiopy:masterfrom
smoia:fix/history

Conversation

@smoia
Copy link
Member

@smoia smoia commented Aug 23, 2024

Closes #76, #77, #78

@me-pic I went straight to the source of the problem - could you check if it works?
I think it's a more elegant solution than fiddling around downstream in the workflow.

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1) label Aug 23, 2024
@smoia smoia requested a review from me-pic August 23, 2024 07:34
Copy link
Contributor

@me-pic me-pic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! 🎉
Works fine for me !

@smoia
Copy link
Member Author

smoia commented Aug 27, 2024

@me-pic does it work fine for you? Can I merge after updating the zenodo?

@github-actions github-actions bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Aug 27, 2024
@smoia smoia removed the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Aug 27, 2024
@smoia smoia merged commit 1ebf46a into physiopy:master Aug 27, 2024
@smoia smoia deleted the fix/history branch August 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save_history fails with TypeError

2 participants