Fix type errors in exporting history after manually adding peaks #79
Merged
smoia merged 1 commit intophysiopy:masterfrom Aug 27, 2024
Merged
Fix type errors in exporting history after manually adding peaks #79smoia merged 1 commit intophysiopy:masterfrom
smoia merged 1 commit intophysiopy:masterfrom
Conversation
me-pic
approved these changes
Aug 23, 2024
Contributor
me-pic
left a comment
There was a problem hiding this comment.
Good catch ! 🎉
Works fine for me !
Member
Author
|
@me-pic does it work fine for you? Can I merge after updating the zenodo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76, #77, #78
@me-pic I went straight to the source of the problem - could you check if it works?
I think it's a more elegant solution than fiddling around downstream in the workflow.
Proposed Changes
Change Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review