Skip to content

Fix: Correct assignment bug in check_troughs#99

Open
sejalpunwatkar wants to merge 2 commits intophysiopy:masterfrom
sejalpunwatkar:fix/check-troughs-bug
Open

Fix: Correct assignment bug in check_troughs#99
sejalpunwatkar wants to merge 2 commits intophysiopy:masterfrom
sejalpunwatkar:fix/check-troughs-bug

Conversation

@sejalpunwatkar
Copy link

Closes #88

This PR fixes a small bug in the check_troughs function where the final trough was not being correctly assigned due to a == comparison instead of =. No other functionality has been changed.

Proposed Changes

  • Fixed the assignment bug in all_troughs[-1] line in check_troughs function
  • Ensured the function now correctly handles the final trough assignment
  • No other code changes or logic updates were made

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small error in Check Troughs function and naming convention

1 participant