Conversation
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 95.85% 94.78% -1.07%
==========================================
Files 29 9 -20
Lines 2314 844 -1470
==========================================
- Hits 2218 800 -1418
+ Misses 96 44 -52 |
|
(BTW, I set up the GH_TOKEN as an organisation secret. Is that right?) |
eurunuela
left a comment
There was a problem hiding this comment.
I guess this looks good. I don't think I'm the best person to review this PR though.
| "overwrite": true | ||
| }, | ||
| { | ||
| "name": "Minormod-breaking", |
There was a problem hiding this comment.
Is this still valid when phys2bids is past alpha (i.e., 1.0.0+)?
There was a problem hiding this comment.
We could remove it, but honestly it' mainly there to maintain the same configuration across physiopy. I doubt we'll ever use that label!
tsalo
left a comment
There was a problem hiding this comment.
My review is basically the same as @eurunuela's. I read through everything and it makes sense, but since I'm not familiar with auto, I'm not sure how valuable my review is.
(BTW, I set up the
GH_TOKENas an organisation secret. Is that right?)
That seems reasonable. It looks like you need to add your personal access token to the GitHub repository's secret environmental variables. I'm not sure if organization-level secrets are automatically used for individual repositories, but it makes sense that they would be.
|
I say we give this a shot if you feel comfortable with it @smoia |
|
Ok, let's try this out. |
|
🚀 PR was released in |

Closes #311 and closes #239
Second attempt to integrate
autoas a workflow, this time as a GitHub action. IF this works, we have a great automated workflow from PR merge to Pypi package (with the other workflow).Proposed Changes
.autorcconfiguration fileI can't wait to see if this works. So exciting!
@hipstersmoothie, could you please have a look at this PR?
@yarikoptic and @jwodder, you could have a look into this too - if you implemented a different solution I'd like to compare them, and otherwise if this works it should help you with datalad/datalad#4999 and dandi/dandi-cli#252!