Skip to content

Fix naming of metrics, clarify PULSE RATE vs HEART RATE#44

Merged
smoia merged 1 commit intophysiopy:masterfrom
smoia:feat/hrv
Aug 18, 2023
Merged

Fix naming of metrics, clarify PULSE RATE vs HEART RATE#44
smoia merged 1 commit intophysiopy:masterfrom
smoia:feat/hrv

Conversation

@smoia
Copy link
Member

@smoia smoia commented Aug 18, 2023

Closes #

Proposed Changes

  • Changes name of heart_rate_variability to heart_rate, add heart_rate_variability

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility label Aug 18, 2023
@smoia smoia merged commit f60d6b9 into physiopy:master Aug 18, 2023
@smoia smoia added the Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) Minormod-breaking For development only, this PR increments the minor version (0.+1.0) but breaks compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant