Skip to content

Implement the workflow#6

Closed
celprov wants to merge 2 commits intophysiopy:masterfrom
celprov:enh/rb_workflow
Closed

Implement the workflow#6
celprov wants to merge 2 commits intophysiopy:masterfrom
celprov:enh/rb_workflow

Conversation

@celprov
Copy link
Copy Markdown
Collaborator

@celprov celprov commented Jul 21, 2023

Closes #

This PR implements the workflow.

Proposed Changes

  • Implement a parser (strongly inspired by the parser of phys2denoise)
  • Add an interface to iteratively generates the figures
  • Add an interface to compute the metrics iteratively
  • Add an interface to save the metrics as a json or csv
  • Adapt the documentation to the reality that certain metrics function can take as input a peakdet Physio object or a np.array

!! The generation of the visual report is missing in the workflow and needs to be added !!

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

…at it can take as input either a np.array or a peakdet Physio object
@celprov celprov force-pushed the enh/rb_workflow branch 2 times, most recently from e419311 to 59f4ff0 Compare July 21, 2023 19:19
@smoia smoia requested a review from m-miedema December 5, 2023 20:57
@celprov
Copy link
Copy Markdown
Collaborator Author

celprov commented Dec 5, 2023

Duplicated in #11

@celprov celprov closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant